Reduce duplicated stake and unstake validation code #2588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drcpu-github
force-pushed
the
feat/stake-unstake-revalidation
branch
from
7d4aef9 to
baa9605
Compare
…lying on the validation module
drcpu-github
force-pushed
the
feat/stake-unstake-revalidation
branch
from
baa9605 to
d61cb0b
Compare
drcpu-github
force-pushed
the
feat/stake-unstake-revalidation
branch
from
d5bec27 to
fe9754f
Compare
…tions to detect invalidated transactions
drcpu-github
force-pushed
the
feat/stake-unstake-revalidation
branch
3 times, most recently
from
237e698 to
42c2157
Compare
drcpu-github
force-pushed
the
feat/stake-unstake-revalidation
branch
from
42c2157 to
ecb0cf6
Compare
drcpu-github
force-pushed
the
feat/stake-unstake-revalidation
branch
3 times, most recently
from
1792b84 to
dda3e36
Compare
|
Is this extensively tested against the public testnet? |
I have been running d61cb0b and ac23127 on several of my testnet nodes. That's the only way we actually can stake / unstake since the original Docker release was bugged. All other changes are RPC-related changes, so those should not break anything. |
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.